Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Compose Builder to Support PostgreSQL as Database #464

Merged
merged 2 commits into from
Oct 3, 2024
Merged

feat: Update Compose Builder to Support PostgreSQL as Database #464

merged 2 commits into from
Oct 3, 2024

Conversation

jackchenjc
Copy link
Contributor

@jackchenjc jackchenjc commented Sep 29, 2024 •
edited
Loading

closes #463

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Run the following command to test EdgeX services with PostgreSQL as database from /compose-builder folder in non-secure mode

make run no-secty keeper mqtt-bus postgres

or

make run no-secty keeper mqtt-bus postgres arm64

Or secure mode

make run keeper mqtt-bus postgres

or

make run keeper mqtt-bus postgres arm64

@jackchenjc jackchenjc requested a review from cloudxxx8 October 1, 2024 10:49
@cloudxxx8 cloudxxx8 requested a review from cherrycl October 2, 2024 01:30
cherrycl
cherrycl requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@cherrycl cherrycl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the support-cron-scheduler to docker-compose-base-postgres.yml, it seems not have to use a standalone file.

There are some changed files also using on the taf or base yaml files. Please also run make build to update the files.

@jackchenjc
Copy link
Contributor Author

The support-cron-scheduler service need to be in a separated file for now so that the make down and make clean commands can work without errors.

@jackchenjc
fix: Update built files
cb688ab 
Signed-off-by: Jack Chen <[email protected]>
cherrycl
cherrycl approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@cherrycl cherrycl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cherrycl cherrycl merged commit 05fa00a into edgexfoundry:main Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherrycl cherrycl cherrycl approved these changes

@cloudxxx8 cloudxxx8 Awaiting requested review from cloudxxx8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Compose Builder to Support PostgreSQL as Database
2 participants
@jackchenjc @cherrycl